Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33818 ) Change subject: BTS_Test_ASCI: Add Talker detect and link fail test ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File bts/BTS_Tests_ASCI.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33818/comment/475510f9_0149… PS4, Line 238: log2str No need to use `log2str` here, `setverdict` does support argument concatenation: ``` setverdict(fail, "RSL_CHAN_RQD was not expected: ", rm); ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33818 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3b292f6a5f47298195bd942a5ca73d9d63f921b5 Gerrit-Change-Number: 33818 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 19 Jul 2023 11:03:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment