Attention is currently required from: fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31341 )
Change subject: pcu_l1_if_phy: flexible phy access ......................................................................
Patch Set 7: Code-Review+1
(2 comments)
File src/osmobts_sock.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/31341/comment/ccf26d2a_1ef0c163 PS5, Line 115: bts->trx[trx].fl1h = NULL;
l1if_close_pdch exists when the_pcu->phy_ops (see above). I think it should be ok.
If you want to make it mandatory for any driver to implement that function then yes it's fine
File src/pcu_l1_if.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/31341/comment/1b16ee3b_17844078 PS5, Line 218: the_pcu->phy_ops->l1if_pdch_req(bts->trx[trx].fl1h, ts, 0, fn, arfcn, block_nr,
It checks for the_pcu->phy_ops. […]
Again, this makes this function mandatory to be implemented by the driver.
-
pespin