Attention is currently required from: fixeria, dexter.

Patch set 7:Code-Review +1

View Change

2 comments:

• File src/osmobts_sock.c:

  • Patch Set #5, Line 115: bts->trx[trx].fl1h = NULL;

    l1if_close_pdch exists when the_pcu->phy_ops (see above). I think it should be ok.

    If you want to make it mandatory for any driver to implement that function then yes it's fine

• File src/pcu_l1_if.cpp:

  • Patch Set #5, Line 218: the_pcu->phy_ops->l1if_pdch_req(bts->trx[trx].fl1h, ts, 0, fn, arfcn, block_nr,

    It checks for the_pcu->phy_ops. […]

    Again, this makes this function mandatory to be implemented by the driver.

To view, visit change 31341. To unsubscribe, or for help writing mail filters, visit settings.