Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27222 )

Change subject: libosmo-pfcp: implement/generate TLV and IE value coding ......................................................................

Patch Set 9:

(1 comment)

Patchset:

PS9: here i cannot satisfy the linter in these 15 instances like

src/libosmo-pfcp/pfcp_ies_custom.c:85: ERROR:SPACING: spaces required around that '==' (ctx:BxW)

because of this construct:

#define ENSURE_LENGTH_IS(CONDITION) \ do { \ if (!(tlv->len CONDITION)) \ RETURN_ERROR(-EINVAL, "IE has length = %zu, expected length " #CONDITION, tlv->len); \ } while (0)

...

ENSURE_LENGTH_IS(>= 2);

When I add a space between '(' and '>=', I get:

space prohibited after that open parenthesis '('

I'd rather keep the macro, to not dup the error message... At the same time the linter is technically correct in refusing. Any opinions?