[S] Change in pysim[master]: pySim.esim.saip.personalization: Support Milenage customization - gerrit-log

16 Dec 2025


      Attention is currently required from: dexter, laforge, neels.
fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41690?usp=email )
Change subject: pySim.esim.saip.personalization: Support Milenage customization
......................................................................
Patch Set 1:
(2 comments)
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/41690/comment/2c5a228f_bf8463e4?usp=ema... :
PS1, Line 331: raise('Length of value must be 5 octets')
Raise an exception, not a string (linter).
https://gerrit.osmocom.org/c/pysim/+/41690/comment/7b8eba9e_e28ba023?usp=ema... :
PS1, Line 340: raise('Length of value must be 80 octets')
Raise an exception, not a string (linter).
-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/41690?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I397df6c0c708a8061e4adc0fde03a3f746bcb5b6
Gerrit-Change-Number: 41690
Gerrit-PatchSet: 1
Gerrit-Owner: laforge laforge@osmocom.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter pmaier@sysmocom.de
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: neels nhofmeyr@sysmocom.de
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Tue, 16 Dec 2025 17:07:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No