laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28055 )

Change subject: bankd: Log more clearly if we fail to open a PC/SC reader ......................................................................

bankd: Log more clearly if we fail to open a PC/SC reader

Related: SYS#5950 Change-Id: I424f585a8a37f21806898e59e350201119645a21 --- M src/bankd/bankd_pcsc.c 1 file changed, 7 insertions(+), 1 deletion(-)

Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved

diff --git a/src/bankd/bankd_pcsc.c b/src/bankd/bankd_pcsc.c index d7bb39c..ee01c93 100644 --- a/src/bankd/bankd_pcsc.c +++ b/src/bankd/bankd_pcsc.c @@ -237,13 +237,19 @@ &dwActiveProtocol); if (rc == SCARD_S_SUCCESS) result = 0; - else + else { LOGW_PCSC_ERROR(worker, rc, "SCardConnect"); + goto out_readerfree; + } break; } p += strlen(p) + 1; }

+ if (result < 0) + LOGW(worker, "Error: Cannot find PC/SC reader/slot matching using regex '%s'\n", worker->reader.name); + +out_readerfree: SCardFreeMemory(worker->reader.pcsc.hContext, mszReaders);

out_regfree: