Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28602 )

Change subject: Add initial SBc-AP support to osmo-cbc ......................................................................

Patch Set 4:

(5 comments)

File src/cbc_main.c:

https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/9df020d2_c50dfa38 PS4, Line 284: perr copy+paste error. Should be SBc-AP ad not CBSP.

File src/cbc_vty.c:

https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/ae9e75f5_8999d510 PS4, Line 539: cfg_peer_proto why is it deprecated?

File src/message_handling.c:

https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/7318acd9_e6164e7f PS4, Line 151: CBSP copy+paste

File src/sbcap_server.c:

https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/7bbc5e3e_da5ee4d7 PS4, Line 33: //#include <osmocom/gsm/sbcap.h> : //#include <osmocom/gsm/protocol/gsm_48_049.h> those can certainly go?

File src/sbcap_server_fsm.c:

https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/be04cf5b_2eeb5a71 PS4, Line 25: / remove?