Attention is currently required from: dexter, fixeria, laforge, pespin.

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36363?usp=email )

Change subject: Convert RTP/RTCP/OSMUX I/O from osmo_fd to osmo_io ......................................................................

Patch Set 5: Code-Review+1

(5 comments)

Patchset:

PS5: this patch is "high density" so probably will be able to know its details only after we merged and use it...

File include/osmocom/mgcp/mgcp.h:

https://gerrit.osmocom.org/c/osmo-mgw/+/36363/comment/d88469b5_002c9042 PS5, Line 4: * maybe time to bump the (C)

File src/libosmo-mgcp/mgcp_network.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/36363/comment/66e82d32_ec1b345d PS4, Line 1047: * \param[in] msg message buffer that holds the data to be send.

Done

(What works quite well is to put a msgb in OTC_SELECT, then any code path can talloc_steal() to claim it, and if no-one does it is freed implicitly. and we avoid the numerous stages of "error? then free. else not." Also sometimes nice to avoid msgb copying.)

File src/libosmo-mgcp/mgcp_network.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/36363/comment/7402418b_c03ae728 PS5, Line 1044: c typo

https://gerrit.osmocom.org/c/osmo-mgw/+/36363/comment/c6d2026b_7e9c1392 PS5, Line 1598: NOTICE ERROR?