Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32397 ) Change subject: alloc_algo: Pass a struct containing all req params ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/pcu_vty_functions.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/32397/comment/6df47316_38ca2994 PS3, Line 156: This looks weird. You added thus ws in previous patch but removing here? Same below. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie4d9ace526ad012d97738bc55bdb5cc1472c632d Gerrit-Change-Number: 32397 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Apr 2023 09:48:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment