Attention is currently required from: dexter.

laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38195?usp=email )

Change subject: filesystem: pass total_len to construct of when encoding file contents ......................................................................

Patch Set 5:

(1 comment)

File pySim/filesystem.py:

https://gerrit.osmocom.org/c/pysim/+/38195/comment/71231ec9_7a1d14da?usp=ema... : PS2, Line 1338: def _decode_bin(self, raw_bin_data: bytearray): : chunks = [raw_bin_data[i:i+self.rec_len] : for i in range(0, len(raw_bin_data), self.rec_len)] : return [self.decode_record_bin(x) for x in chunks] : : def _encode_bin(self, abstract_data) -> bytes: : chunks = [self.encode_record_bin(x) for x in abstract_data] : # FIXME: pad to file size : return b''.join(chunks)

I am still not sure about the kwargs scheme used with the methods. […]

There's nothing wrong with anticipating future extensions and passing through `**kwargs`. We just need to do it consistently, IMHO.