Attention is currently required from: dexter.

View Change

1 comment:

• File pySim/filesystem.py:

  • Patch Set #2, Line 1338:

       def _decode_bin(self, raw_bin_data: bytearray):
            chunks = [raw_bin_data[i:i+self.rec_len]
                      for i in range(0, len(raw_bin_data), self.rec_len)]
            return [self.decode_record_bin(x) for x in chunks]
    
        def _encode_bin(self, abstract_data) -> bytes:
            chunks = [self.encode_record_bin(x) for x in abstract_data]
            # FIXME: pad to file size
            return b''.join(chunks)
    

    I am still not sure about the kwargs scheme used with the methods. […]

    There's nothing wrong with anticipating future extensions and passing through `**kwargs`. We just need to do it consistently, IMHO.

To view, visit change 38195. To unsubscribe, or for help writing mail filters, visit settings.