Attention is currently required from: matanp. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33750 ) Change subject: ctrl: Support adding si2quater earfcn neighbor ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/osmo-bsc/bts_ctrl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/33750/comment/03b5583f_12ff187e PS3, Line 888: if ((0 == result) && (si2q_num(bts) <= SI2Q_MAX_NUM)) { we usuall compare "var == value" not the other way around. Please reverse it (you are even already do it as usual in the other comparison in same line). -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33750 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifd2740ee54db66742785437a278cb9244e1f76d0 Gerrit-Change-Number: 33750 Gerrit-PatchSet: 3 Gerrit-Owner: matanp &lt;matan1008(a)gmail.com&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: matanp &lt;matan1008(a)gmail.com&gt; Gerrit-Comment-Date: Fri, 14 Jul 2023 12:15:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment