Attention is currently required from: pespin.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-upf/+/28312
)
Change subject: implement GTPv1-U ECHO response
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-upf/upf_gtpu_echo.c:
https://gerrit.osmocom.org/c/osmo-upf/+/28312/comment/310f1b2a_e9945117
PS1, Line 61: msg = msgb_alloc_headroom(1024, 128, "GTP-echo-resp");
Would be good having this in a tx_echo_resp function.
the rx part is so trivial and it is a private function, but separate tx is
semantically nicer indeed
--
To view, visit
https://gerrit.osmocom.org/c/osmo-upf/+/28312
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I135370a7723e2c667ec681f50c21107cde63ea5b
Gerrit-Change-Number: 28312
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 18 Jun 2022 11:50:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment