Attention is currently required from: Hoernchen.

laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email )

Change subject: ccid: properly emit wait time ext messages ......................................................................

Patch Set 3:

(1 comment)

File ccid_common/iso7816_fsm.h:

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306/comment/86bdc1ab_fb2... : PS2, Line 25: ISO7816_E_RX_SINGLE, /*!< single-byte data received on UART */

And how is reformatting changed code in a patch preceding the patch changing the code supposed to wo […]

I don't understant why it's so hard to first reformat the code, and then add your changes on top of it? We can debate all day long how annoying the situation is, and I'm open for whatever solutions there might be, just as long as we keep our commit history clean and never mix unrelated formatting changes with actual functional code changes. That shouldn't be any surprise at all, and interestingly we rarely see any other developer even submitting something like that for review in the first place.