Attention is currently required from: osmith, daniel.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/docker-playground/+/30770 )
Change subject: network_create: find free subnet automatically
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File jenkins-common.sh:
https://gerrit.osmocom.org/c/docker-playground/+/30770/comment/01963a39_19c…
PS2, Line 211: SUBNET="$(echo "($SUBNET + 1) % 256" | bc)"
I was about to say that with $(expr ...) this can be done simpler:
SUBNET=$(expr ($SUBNET + 1) % 256)
but as it turned out it requires escaping of the parentheses:
SUBNET=$(expr \( $SUBNET + 1 \) % 256)
--
To view, visit
https://gerrit.osmocom.org/c/docker-playground/+/30770
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I57152b08ef0f38e17e7019a8df032189b03f56cf
Gerrit-Change-Number: 30770
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 16 Jan 2023 15:00:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment