Attention is currently required from: osmith, daniel.

Patch set 2:Code-Review +2

View Change

1 comment:

• File jenkins-common.sh:

  • Patch Set #2, Line 211: SUBNET="$(echo "($SUBNET + 1) % 256" | bc)"

    I was about to say that with $(expr ...) this can be done simpler:

      SUBNET=$(expr ($SUBNET + 1) % 256)

    but as it turned out it requires escaping of the parentheses:

      SUBNET=$(expr \( $SUBNET + 1 \) % 256)

To view, visit change 30770. To unsubscribe, or for help writing mail filters, visit settings.