fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27754 )

Change subject: rsl: rsl_rx_chan_{activ,modif}: do not sent an Error Report ......................................................................

rsl: rsl_rx_chan_{activ,modif}: do not sent an Error Report

Sending an Error Report along with a NACK makes no sense.

Change-Id: Idae55645c34970f839bb0eef61a7326a1026b20c Related: SYS#5917, OS#4984 --- M src/common/rsl.c 1 file changed, 2 insertions(+), 6 deletions(-)

Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified

diff --git a/src/common/rsl.c b/src/common/rsl.c index 09444d1..2da954d 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -1855,10 +1855,8 @@

/* 9.3.52 MultiRate Configuration */ rc = parse_multirate_config(lchan, &tp); - if (rc < 0) { - rsl_tx_error_report(msg->trx, -rc, &dch->chan_nr, NULL, msg); + if (rc < 0) return rsl_tx_chan_act_acknack(lchan, -rc); - }

/* 9.3.53 MultiRate Control */ /* 9.3.54 Supported Codec Types */ @@ -2204,10 +2202,8 @@

/* 9.3.52 MultiRate Configuration */ rc = parse_multirate_config(lchan, &tp); - if (rc < 0) { - rsl_tx_error_report(msg->trx, -rc, &dch->chan_nr, NULL, msg); + if (rc < 0) return rsl_tx_mode_modif_nack(lchan, -rc); - }

/* 9.3.53 MultiRate Control */ /* 9.3.54 Supported Codec Types */