Attention is currently required from: dexter, fixeria. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34336?usp=email ) Change subject: filesystem: add attribute "leftpad" to class LinFixedEF ...................................................................... Patch Set 1: (2 comments) File pySim/ts_51_011.py: https://gerrit.osmocom.org/c/pysim/+/34336/comment/e1a6e485_963bfede PS1, Line 184: leftpad @fixeria asked me to review this change - but I don't feel qualified because (1) I don't speak Python and (2) I am not familiar at all with the architecture of current pysim. I can, however, comment on the GSM/3GPP spec aspect of things. Vadim is correct in that the variable-length space in the EF.MSISDN record that precedes the 14-byte fixed part is not just padding, but an alpha tag or alpha identifier. Most SIM card issuers, or end users programming this file for themselves (it is user-writable per the specs), leave the alpha tag empty, filling that space with 0xFF bytes - hence that space often looks like padding. However, some people do put non-empty alpha tag strings in there: for example, EF.MSISDN alpha tag on Mexican SIMs reads as "Mi numero", meaning "My number" in Spanish. Looking at another annotated change line below, it appears to me (once again without actually knowing much of anything about current pysim) that you do NOT currently support setting the alpha tag to anything other than FF-fill, which a spec-compliant reader will see as an empty string. Whether or not pysim should support setting non-empty alpha tags on EF.MSISDN, it is not my place to say - but my competing/alternative tool fc-simtool does support setting alpha tags on all SIM records where the specs provide for such. https://gerrit.osmocom.org/c/pysim/+/34336/comment/0e749f0c_f0e0aecd PS1, Line 195: alpha_identifier = (list(self.rec_len)[0] - len(encoded_msisdn) // 2) * "ff" This line leads me to assume that current pysim does not support entering non-empty alpha tags for this record. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34336?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I241d9fd656f9064a3ebb4e8e01a52b6b030f9923 Gerrit-Change-Number: 34336 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Sep 2023 19:58:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment