Attention is currently required from: laforge, osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35287?usp=email ) Change subject: stream_srv_link: osmo_stream_srv_link_get_sockname() now returns the full set of addresses ...................................................................... Patch Set 3: (3 comments) File src/stream_srv.c: https://gerrit.osmocom.org/c/libosmo-netif/+/35287/comment/9843106a_da6d1729 PS3, Line 364: "<need-more-bufs!>" This string (or some part of it) may not make it to the output buffer if there is not enough room in `hostbuf[][]`. Do you think it's fine to return a result mixed up with an error message, which may not even fit? https://gerrit.osmocom.org/c/libosmo-netif/+/35287/comment/18818ce0_e0d91e9c PS3, Line 371: NULL in case of error this is no longer true https://gerrit.osmocom.org/c/libosmo-netif/+/35287/comment/9e50c074_1132561f PS3, Line 467: get_local_sockname_buf Do we want to check return value against NULL here? Or somehow make sure that we do not end up with `link->sockname` being `<some-error>`. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35287?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I216502a9aeafe638940f110bc9fddf2504b2ac3a Gerrit-Change-Number: 35287 Gerrit-PatchSet: 3 Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Attention: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Comment-Date: Tue, 12 Dec 2023 12:58:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment