Attention is currently required from: laforge, osmith, pespin.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35287?usp=email )

Change subject: stream_srv_link: osmo_stream_srv_link_get_sockname() now returns the full set of addresses ......................................................................

Patch Set 3:

(3 comments)

File src/stream_srv.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/35287/comment/9843106a_da6d1729 PS3, Line 364: "<need-more-bufs!>" This string (or some part of it) may not make it to the output buffer if there is not enough room in `hostbuf[][]`. Do you think it's fine to return a result mixed up with an error message, which may not even fit?

https://gerrit.osmocom.org/c/libosmo-netif/+/35287/comment/18818ce0_e0d91e9c PS3, Line 371: NULL in case of error this is no longer true

https://gerrit.osmocom.org/c/libosmo-netif/+/35287/comment/9e50c074_1132561f PS3, Line 467: get_local_sockname_buf Do we want to check return value against NULL here? Or somehow make sure that we do not end up with `link->sockname` being `<some-error>`.