Attention is currently required from: laforge, osmith, pespin.

View Change

3 comments:

• File src/stream_srv.c:

  • Patch Set #3, Line 364: "<need-more-bufs!>"

    This string (or some part of it) may not make it to the output buffer if there is not enough room in `hostbuf[][]`. Do you think it's fine to return a result mixed up with an error message, which may not even fit?

  • Patch Set #3, Line 371: NULL in case of error

    this is no longer true

  • Patch Set #3, Line 467: get_local_sockname_buf

    Do we want to check return value against NULL here?
    Or somehow make sure that we do not end up with `link->sockname` being `<some-error>`.

To view, visit change 35287. To unsubscribe, or for help writing mail filters, visit settings.