pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39249?usp=email )

(

2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mgw: Remove wrong TODO comment ......................................................................

mgw: Remove wrong TODO comment

The TODO was written because the author had in mind the ptr where the codec was stored was a MGCP endpoint object, but it is actually an rtp_end which is an object under conn_rtp, so that's fine already with current code.

Change-Id: I99d2211e81443883c45cc3fdda10e39a8c152063 --- M src/libosmo-mgcp/mgcp_protocol.c 1 file changed, 0 insertions(+), 1 deletion(-)

Approvals: Jenkins Builder: Verified daniel: Looks good to me, approved neels: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve

diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index 8dcb686..7095058 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -1185,7 +1185,6 @@ goto error3; } /* Upgrade the conn type RTP_DEFAULT->RTP_IUUP if needed based on requested codec: */ - /* TODO: "codec" probably needs to be moved from endp to conn */ if (conn_rtp->type == MGCP_RTP_DEFAULT && strcmp(conn_rtp->end.cset.codec->subtype_name, "VND.3GPP.IUFP") == 0) rc = mgcp_conn_iuup_init(conn_rtp);