Attention is currently required from: Hoernchen.

laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759?usp=email )

Change subject: Make ch9 usb tests work ......................................................................

Patch Set 1: Code-Review+1

(4 comments)

File contrib/ch9_epstall.py:

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/b8bd9c0e_34c... : PS1, Line 3: ch9 usb ep halt test Does that test have a name/number? If so, it would be good to add as a spec reference.

File contrib/gdb_clocktree.py:

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/3f466ed4_e3c... : PS1, Line 1: import gdb please add copyright/author and at least a brief summary.

File contrib/gdb_sercom.py:

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/b44419f7_7e3... : PS1, Line 1: import gdb a line with author / copyright information is missing, and at least a very high-level description of what it is about (yes something for gdb related to the SERCOM peripheral... but what?)

File contrib/gdb_usb.py:

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/481779de_5f3... : PS1, Line 3: same here: copyright/author/brief description