[XS] Change in osmo-trx[master]: transceiver: return -EINVAL for invalid SETSLOT and preserve original... - gerrit-log

17 Mar 2026


      Attention is currently required from: Timur Davydov.
pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42421?usp=email )
Change subject: transceiver: return -EINVAL for invalid SETSLOT and preserve original behavior
......................................................................
Patch Set 1:
(1 comment)
File Transceiver52M/Transceiver.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/42421/comment/4f48d959_ecae261c?usp=... :
PS1, Line 1090:     return rc == -EINVAL ? 0 : rc; /* Ignore invalid values, but report other errors */
why ignore it here? I'd actually propagate the error since it means there was an error, there's no negative timeslot nor >7.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42421?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I90bda68268abdeee9c766a3bf4189fba8f13da53
Gerrit-Change-Number: 42421
Gerrit-PatchSet: 1
Gerrit-Owner: Timur Davydov dtv.comp@gmail.com
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: Timur Davydov dtv.comp@gmail.com
Gerrit-Comment-Date: Tue, 17 Mar 2026 08:06:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No