Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28157 ) Change subject: pgw: Improve checks around Gy messages ...................................................................... Patch Set 2: (1 comment) File pgw/PGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28157/comment/6fdf5abd_1bf9… PS2, Line 336: //msisdn := char2oct(f_dec_TBCD(substr(ctx_val.msisdn, 1, lengthof(ctx_val.msisdn) -1))); Yes, I didn't fully implement/validate this now yet for PGW, since I have more urgent/interesting stuff to test/develop (priority of this field being checked changed while I was developing it). I'll spend time doing this later if so. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28157 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ica3ca4cf72113d66e74dcff9f838e39cc5d63468 Gerrit-Change-Number: 28157 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 May 2022 15:20:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment