Attention is currently required from: pespin.

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32083 )

Change subject: mgcp_codec: refactor payload type converstion ......................................................................

Patch Set 2:

(1 comment)

File src/libosmo-mgcp/mgcp_network.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/32083/comment/0ee60367_4f89d1da PS2, Line 516: codec_dst = mgcp_codec_find_convertible(conn_dst, codec_src);

IIUC you also need to do a 2 stage check here. […]

The function mgcp_codec_find_convertible always prefers codecs that are the same. Only when there are no codecs that are the same, then a convertible codec is picked.

(it is assumed that that a "same" codec is always convertible)