Attention is currently required from: fixeria, pespin, dexter.

jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33448 )

Change subject: ASCI: Add Notification/FACCH support ......................................................................

Patch Set 6:

(3 comments)

File include/osmo-bts/notification.h:

https://gerrit.osmocom.org/c/osmo-bts/+/33448/comment/fc4a1947_2ff8fc2b PS5, Line 60: int facch_gen_msg(struct gsm_bts *bts, uint8_t *out_buf, const uint8_t *group_call_ref, const uint8_t *chan_desc,

As far as I understand this is an ASCI related function. […]

Done

File src/common/rsl.c:

https://gerrit.osmocom.org/c/osmo-bts/+/33448/comment/f36a6db5_af29deaa PS5, Line 814: broadcast_facch

Maybe it would be good to add a comment to clarify this?

Done

https://gerrit.osmocom.org/c/osmo-bts/+/33448/comment/d28634e5_81a8f0c3 PS5, Line 814: static int broadcast_facch(struct gsm_bts *bts, const uint8_t *group_call_ref, const uint8_t *chan_desc,

maybe rename this asci_broadcast_facch, so that it is more clear that this function is asci related? […]

Done