Attention is currently required from: osmith, fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27465 )
Change subject: treewide: tweak includes
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
File src/osmo-bsc-nat/bsc_nat.c:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27465/comment/ee77c545_e51f1696
PS1, Line 23: #include <osmocom/core/talloc.h>
Usually includes from libraries come first, and then
local headers follow.
Ack
File src/osmo-bsc-nat/bsc_nat_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27465/comment/68dd16af_9f9e3c16
PS1, Line 30: #include <stdint.h>
Same here.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27465
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc-nat
Gerrit-Branch: master
Gerrit-Change-Id: I1a7b95ccb0c87fd53645c72f0c02449e8403043b
Gerrit-Change-Number: 27465
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 10 Mar 2022 15:01:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment