Attention is currently required from: daniel, fixeria, pespin.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34526?usp=email )
Change subject: meas_feed: Use osmo_io instead of write queue ......................................................................
Patch Set 7:
(3 comments)
File src/osmo-bsc/meas_feed.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/34526/comment/24c2c084_401fadb8 PS5, Line 148: &(struct osmo_io_ops) { : .read_cb = meas_feed_noop_cb, : .write_cb = meas_feed_noop_cb, : .segmentation_cb = NULL, : }, NULL);
@vyanitskiy@sysmocom. […]
Done
File src/osmo-bsc/meas_feed.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/34526/comment/374cc3cf_123b50dd PS6, Line 33: static struct meas_feed_state g_mfs = {.txqueue_max = MEAS_FEED_TXQUEUE_MAX_LEN_DEFAULT};
I gree with Daniel, we usually use the way he proposed. […]
I hope it's okay with `g_mfs` as a oneliner, I have added the space before and after.
https://gerrit.osmocom.org/c/osmo-bsc/+/34526/comment/aeea4ec6_0e28a606 PS6, Line 133: struct osmo_io_ops meas_feed_oio = {.read_cb = NULL, .write_cb = meas_feed_noop_cb,
Ack
Done
-
arehbein