Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41359?usp=email )

Change subject: Add ER-GSM band support to all relevant applications ......................................................................

Patch Set 1:

(5 comments)

File src/host/layer23/src/common/settings.c:

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmocom-bb/+/41359/comment/9e504b0c_1a0b247d?us... : PS1, Line 187: for(i = 940; i <= 954; i++) space required before the open parenthesis '('

File src/target/firmware/apps/rssi/main.c:

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmocom-bb/+/41359/comment/6bc36477_69543215?us... : PS1, Line 82: { 940, 124, 885, 128, 8732, 9182 }, /* P,E,(E)R GSM */ code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmocom-bb/+/41359/comment/121462b5_86ff8d43?us... : PS1, Line 82: { 940, 124, 885, 128, 8732, 9182 }, /* P,E,(E)R GSM */ please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmocom-bb/+/41359/comment/9fb1599e_1e9761af?us... : PS1, Line 83: { 512, 885, 251, 940, 17102, 18052 }, /* DCS 1800 */ code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmocom-bb/+/41359/comment/89aa4c5b_daee1dd4?us... : PS1, Line 83: { 512, 885, 251, 940, 17102, 18052 }, /* DCS 1800 */ please, no spaces at the start of a line