Attention is currently required from: manawyrm, roox, tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27845 ) Change subject: octoi: differentiate UNDERRUN from SUBSTITUTED in counters ...................................................................... Patch Set 2: (1 comment) File src/octoi/frame_rifo.c: https://gerrit.osmocom.org/c/osmo-e1d/+/27845/comment/554c8ba1_4325943e PS1, Line 141: if (frame_rifo_depth(rifo) == 0) { yes, I've now fixe this in https://gerrit.osmocom.org/c/osmo-e1d/+/27848 and introduced test coverage in https://gerrit.osmocom.org/c/osmo-e1d/+/27847 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27845 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I5448430b09ec10a16decdfd0a4a40850fe2ed1a6 Gerrit-Change-Number: 27845 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: roox <mardnh(a)gmx.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: roox <mardnh(a)gmx.de> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Wed, 20 Apr 2022 12:54:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: tnt <tnt(a)246tNt.com> Gerrit-MessageType: comment