Attention is currently required from: daniel.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/31172 )
Change subject: Add osmo_sockaddr_size() to return the size of the variant used
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
I like this one, but I'd probably add a big fat warning in the documentation for the
reader to realize this provide eg the "sockaddr_in" and not the
"in_addr", since sometimes that's what's wanted.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/31172
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I952b6bb752441fe019fc18f89bce4bbfbe58994a
Gerrit-Change-Number: 31172
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 03 Feb 2023 15:20:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment