laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27412 )
Change subject: VTY: fix ambiguity in BTS specific command definitions ......................................................................
VTY: fix ambiguity in BTS specific command definitions
Most of the BTS specific VTY commands restrict BTS number to '<0-0>', while bts_c0_power_red_cmd has '<0-255>'. This confuses libosmovty:
OsmoBTS# bts ? <0-0> BTS number <0-255> BTS Number
OsmoBTS# bts 0 ? % Ambiguous command.
OsmoBTS# bts 0 c0-power-red 0 % Ambiguous command.
Let's stick to '<0-0>', we don't support multiple BTS anyway.
Change-Id: I937ac421143678b97627c1bc4fe573831ce097f6 --- M src/common/vty.c M tests/osmo-bts.vty 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified
diff --git a/src/common/vty.c b/src/common/vty.c index 97bd658..8925999 100644 --- a/src/common/vty.c +++ b/src/common/vty.c @@ -1329,7 +1329,7 @@
DEFUN(bts_c0_power_red, bts_c0_power_red_cmd, - "bts <0-255> c0-power-red <0-6>", + "bts <0-0> c0-power-red <0-6>", "BTS Specific Commands\n" BTS_NR_STR "BCCH carrier power reduction operation\n" "Power reduction value (in dB, even numbers only)\n") diff --git a/tests/osmo-bts.vty b/tests/osmo-bts.vty index fb74747..c4b6618 100644 --- a/tests/osmo-bts.vty +++ b/tests/osmo-bts.vty @@ -107,7 +107,7 @@ show timer [(bts|abis)] [TNNNN] bts <0-0> trx <0-255> ts <0-7> (lchan|shadow-lchan) <0-7> rtp jitter-buffer <0-10000> test send-failure-event-report <0-255> - bts <0-255> c0-power-red <0-6> + bts <0-0> c0-power-red <0-6> show e1_driver show e1_line [<0-255>] [stats] show e1_timeslot [<0-255>] [<0-31>]
-
laforge