Attention is currently required from: pespin. dexter has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/39420?usp=email ) Change subject: osmo-upf-load-gen: Improve VTY command helper strings ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/osmo-upf-load-gen/pfcp_tool_vty.c: https://gerrit.osmocom.org/c/upf-benchmark/+/39420/comment/283e6689_6a4b49a… : PS1, Line 222: "Add a core GTP port, to emit GTP1U traffic to\n" Maybe write "remote" instead of "core"? Even though it should be clear that the core network is remote "core GTP port" sounds a bit strange to me. -- To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/39420?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: upf-benchmark Gerrit-Branch: master Gerrit-Change-Id: I69701e875f5c38f434265d93a047c8157daffd29 Gerrit-Change-Number: 39420 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jan 2025 08:47:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes