neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28707 ) Change subject: add some comments in upf_gtp.c ...................................................................... add some comments in upf_gtp.c Related: SYS#5599 Change-Id: I58f86cd84207a74e078ae4758bbed76bb1595d95 --- M src/osmo-upf/upf_gtp.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/osmo-upf/upf_gtp.c b/src/osmo-upf/upf_gtp.c index 8eef49f..2c8f89f 100644 --- a/src/osmo-upf/upf_gtp.c +++ b/src/osmo-upf/upf_gtp.c @@ -96,6 +96,8 @@ static int upf_gtp_dev_destruct(struct upf_gtp_dev *dev); +/* Allocate state for one GTP device, add to g_upf->gtp.devs and return the created device. If state for the device of + * that name already exists, do nothing and return NULL. */ static struct upf_gtp_dev *upf_gtp_dev_alloc(const char *name, const char *local_addr) { struct upf_gtp_dev *dev = upf_gtp_dev_find_by_name(name); @@ -260,9 +262,11 @@ return 0; } + /* Already open? */ if (g_upf->gtp.nl && g_upf->gtp.genl_id >= 0) return 0; + /* sanity / paranoia: if re-opening, make sure the previous socket is closed */ if (g_upf->gtp.nl) upf_gtp_genl_close(); 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28707 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I58f86cd84207a74e078ae4758bbed76bb1595d95 Gerrit-Change-Number: 28707 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged