Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28732 ) Change subject: Support CBSP/TCP and SBc-AP/SCTP client mode ...................................................................... Patch Set 3: Code-Review+1 (2 comments) File src/cbc_vty.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28732/comment/6171e010_ddb5e89b PS3, Line 596: DEFUN I would suggest using DEFUN_ATTR with CMD_ATTR_NODE_EXIT here and in other commands to inform the user that changes are applied on node exit. Can be done later though. File src/cbsp_link.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28732/comment/b8b5049a_26b0faa1 PS3, Line 286: CBC_PEER_LINK_MODE_CLIENT Just wondering: how is it possible? Getting a client connection in client mode... -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28732 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I3ec54b615b41b56f7a9c64298e3fcaac37f4b60e Gerrit-Change-Number: 28732 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 23 Jul 2022 08:52:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment