[L] Change in osmo-pcu[master]: Move out of alloc_algo code modifying the data model - gerrit-log

26 Apr 2023


      Attention is currently required from: osmith, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32399 )
Change subject: Move out of alloc_algo code modifying the data model
......................................................................
Patch Set 8:
(1 comment)
File src/tbf_ul.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/32399/comment/669233eb_d19e1992 
PS8, Line 720: %u
...
`%d` because it's int?
Not needed, because it is guaranteed to be unsigned by the check above (slot allocated) plus it would assert below. We don't really expect a negative value here.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32399
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I5ffd00f5f80bde4b73b78db44896f65e70e12b20
Gerrit-Change-Number: 32399
Gerrit-PatchSet: 8
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria axilirator@gmail.com
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: osmith osmith@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: fixeria axilirator@gmail.com
Gerrit-Comment-Date: Wed, 26 Apr 2023 11:27:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Gerrit-MessageType: comment