[S] Change in libosmocore[master]: logging_gsmtap: Temporarily disable logging when sending the logs - gerrit-log

9 Nov 2023


      Attention is currently required from: arehbein, daniel, fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34966?usp=email )
Change subject: logging_gsmtap: Temporarily disable logging when sending the logs
......................................................................
Patch Set 2:
(1 comment)
File src/core/logging_gsmtap.c:
https://gerrit.osmocom.org/c/libosmocore/+/34966/comment/2ae312bb_d173590a 
PS2, Line 118: level = target->loglevel
...
I believe we should not be overwriting the input parameters for the sake of saving one variable. […]
as daniel is on holidays and this is  a fairly trivial change: @fixeria, would you mind amending this patch and sending an updated version?
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34966?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I19203cadbad6019a3834793b8ac816d903fe088e
Gerrit-Change-Number: 34966
Gerrit-PatchSet: 2
Gerrit-Owner: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein arehbein@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: arehbein arehbein@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: daniel dwillmann@sysmocom.de
Gerrit-Comment-Date: Thu, 09 Nov 2023 12:27:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Gerrit-MessageType: comment