Attention is currently required from: laforge, fixeria.
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32762 )
Change subject: transceiver: pass cfg struct instead of args ......................................................................
Patch Set 4:
(4 comments)
Patchset:
PS4: as per haralds comment we're gonna reformat everything in a followup patch
File Transceiver52M/device/uhd/UHDDevice.h:
https://gerrit.osmocom.org/c/osmo-trx/+/32762/comment/c44c5e11_107240a0 PS3, Line 83: uhd_device(InterfaceType iface, const struct trx_cfg *cfg);
tabs vs spaces inconsistency
Done
File Transceiver52M/device/usrp1/USRPDevice.h:
https://gerrit.osmocom.org/c/osmo-trx/+/32762/comment/70fa78c6_57d370c5 PS3, Line 107: USRPDevice(InterfaceType iface, const struct trx_cfg *cfg);
2 spaces vs 4 spaces inconsistency?
Done
https://gerrit.osmocom.org/c/osmo-trx/+/32762/comment/0525afd3_92e672b4 PS3, Line 120: return TX_WINDOW_USRP1;
what a mix
Done
-
Hoernchen