Attention is currently required from: fixeria, pespin.
Jenkins Builder has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41077?usp=email )
Change subject: aaa_diameter_swx_tests: use MAR record to improve readability
......................................................................
Patch Set 1:
(2 comments)
File src/aaa_diameter_swx_tests.erl:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41077/comment/5e1c425e_0e84…
:
PS1, Line 52: VAID = #'Vendor-Specific-Application-Id'{'Vendor-Id' =
10415,
'VAID' may be misspelled - perhaps 'VALID'?
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41077/comment/8f2be459_f0d3…
:
PS1, Line 61: 'Vendor-Specific-Application-Id' = VAID,
'VAID' may be misspelled - perhaps 'VALID'?
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41077?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I0e77aae792fb9bc2e7277668a4fdda21a993aaa2
Gerrit-Change-Number: 41077
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Sep 2025 20:37:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No