Change in osmocom-bb[master]: trxcon: make l1sched_trigger() accept the [advanced] TDMA Fn - gerrit-log

21 Nov 2022


      Attention is currently required from: fixeria, msuraev.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30238 )
Change subject: trxcon: make l1sched_trigger() accept the [advanced] TDMA Fn
......................................................................
Patch Set 2:
(1 comment)
File src/host/trxcon/src/sched_clck.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30238/comment/c84d2d2e_8ebb7417 
PS2, Line 45: /* Advance TDMA frame number in order to give the transceiver
...
That's pretty confusing: you accept as parameter exact same thing which was computed internally befo […]
Agree with Max, I think you are at least missing explaining a bit the context of this change and what's the improvement.
-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30238
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Icc9127bfacfbb78ab9d74103b2db03be850f3d4f
Gerrit-Change-Number: 30238
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-CC: msuraev msuraev@sysmocom.de
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: msuraev msuraev@sysmocom.de
Gerrit-Comment-Date: Mon, 21 Nov 2022 09:41:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: msuraev msuraev@sysmocom.de
Gerrit-MessageType: comment