Attention is currently required from: neels, laforge, daniel. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/32512 ) Change subject: Add support for multiple APN profiles for subscriber data ...................................................................... Patch Set 8: (5 comments) File include/osmocom/hlr/hlr_ps.h: https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/60989f2f_ebbfe269 PS7, Line 2: Done https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/fb5f808a_f7975993 PS7, Line 28: Done File src/gsup_server.c: https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/eda047de_3bb3dd46 PS7, Line 480: if (g_hlr->ps.pdp_profile.enabled) { Currently no because of backwards compatibility in the configuration. Backwards compatibility means (no configuration), hlr will return apn = '*'. So we have to figure out if this is the old behavior or the new one. On the new one, You could also configure a pdp-profile with no apns which should result in rejecting the PDP requests on the SGSN/MME level. File src/hlr_vty.c: https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/ce8f93ca_ffd1d06f PS5, Line 133: Define a PDP profile set.\n" : "Unique identifier for this PDP profile set.\n") Done File tests/test_nodes.vty: https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/69f8855b_d5c2c1d6 PS7, Line 56: ps aren't doc strings always validated? (without using those vty scripts). -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/32512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I540132ee5dcfd09f4816e02e702927e1074ca50f Gerrit-Change-Number: 32512 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 May 2023 10:04:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment