Attention is currently required from: neels, laforge, daniel.

5 comments:

File include/osmocom/hlr/hlr_ps.h:
- Patch Set #7, Line 2:
  #pragma once
  Done
- Patch Set #7, Line 28:
  (extra blank line)
  Done
File src/gsup_server.c:
- Patch Set #7, Line 480: if (g_hlr->ps.pdp_profile.enabled) {
  maybe include these checks somehow? […]
  Currently no because of backwards compatibility in the configuration.
  Backwards compatibility means (no configuration), hlr will return apn = '*'.
  So we have to figure out if this is the old behavior or the new one.
  On the new one, You could also configure a pdp-profile with no apns which should result in rejecting the PDP requests on the SGSN/MME level.
File src/hlr_vty.c:
- Patch Set #5, Line 133:
```
Define a PDP profile set.\n"
      "Unique identifier for this PDP profile set.\n")
```
  In the future, this may look like this: […]
  Done
File tests/test_nodes.vty:
- Patch Set #7, Line 56: ps
  please also add tests for the command doc strings, to verify all new docs, like […]
  aren't doc strings always validated? (without using those vty scripts).

To view, visit change 32512. To unsubscribe, or for help writing mail filters, visit settings.