Attention is currently required from: neels, laforge, daniel.
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/32512 )
Change subject: Add support for multiple APN profiles for subscriber data ......................................................................
Patch Set 8:
(5 comments)
File include/osmocom/hlr/hlr_ps.h:
https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/60989f2f_ebbfe269 PS7, Line 2:
#pragma once
Done
https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/fb5f808a_f7975993 PS7, Line 28:
(extra blank line)
Done
File src/gsup_server.c:
https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/eda047de_3bb3dd46 PS7, Line 480: if (g_hlr->ps.pdp_profile.enabled) {
maybe include these checks somehow? […]
Currently no because of backwards compatibility in the configuration. Backwards compatibility means (no configuration), hlr will return apn = '*'. So we have to figure out if this is the old behavior or the new one.
On the new one, You could also configure a pdp-profile with no apns which should result in rejecting the PDP requests on the SGSN/MME level.
File src/hlr_vty.c:
https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/ce8f93ca_ffd1d06f PS5, Line 133: Define a PDP profile set.\n" : "Unique identifier for this PDP profile set.\n")
In the future, this may look like this: […]
Done
File tests/test_nodes.vty:
https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/69f8855b_d5c2c1d6 PS7, Line 56: ps
please also add tests for the command doc strings, to verify all new docs, like […]
aren't doc strings always validated? (without using those vty scripts).