Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/38740?usp=email )
Change subject: trxcon/l1sched: fix FACCH/H regression in rx_tchh_fn() ......................................................................
Patch Set 1:
(1 comment)
File src/host/trxcon/src/sched_lchan_tchh.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/38740/comment/92040570_bba94c13?us... : PS1, Line 86: /* TDMA frame number of burst 'f' is used as the table index. */
so you are numbering the bursts a,b,c,d,e,f?
Yes, see the comment above illustrating burst placement in the buffer.
Is that specified like that somewhere?
Not that I am aware of.
Maybe add "(last)" here and "(first)" below?
Ack, it does not hurt to clarify things a bit. In a separate patch though.