Attention is currently required from: daniel, lynxis lazus.
laforge has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/osmo-msc/+/38410?usp=email )
Change subject: vlr: add a logging layer
......................................................................
Patch Set 7: Code-Review+1
(4 comments)
Patchset:
PS7:
doing th
File src/libvlr/vlr.c:
https://gerrit.osmocom.org/c/osmo-msc/+/38410/comment/6d386ce5_1cc40ee3?usp… :
PS6, Line 518: LOGVLR(LOGL_ERROR, "subscr %s: unable to generate valid TMSI"
LOGVSUBP
Done
https://gerrit.osmocom.org/c/osmo-msc/+/38410/comment/f7737de0_ce11af54?usp… :
PS6, Line 591: vlr_subscr_name
could use the LOGVSUBP()
Done
https://gerrit.osmocom.org/c/osmo-msc/+/38410/comment/c1d6307f_5839a622?usp… :
PS6, Line 739: "%s: Could not enable Location Update expiry: unable to read
current time\n", vlr_subscr_name(vsub));
LOGVSUBP
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/38410?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I6d87b38d6d7d704c7c7b2c90ad12187e4b953b8b
Gerrit-Change-Number: 38410
Gerrit-PatchSet: 7
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 25 Nov 2024 16:04:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>