Attention is currently required from: jolly, laforge, pespin.

Hello Jenkins Builder, laforge, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/40584?usp=email

to look at the new patch set (#6).

The following approvals got outdated and were removed: Code-Review-1 by pespin, Verified+1 by Jenkins Builder

Change subject: Avoid reusing pending buffer; append incoming data instead ......................................................................

Avoid reusing pending buffer; append incoming data instead

When reading from a stream, a single read may return only part of a message segment. In such cases, the partial data was stored in 'iofd->pending' and reused for subsequent reads to complete the message.

With upcoming changes that submit multiple read SQEs to io_uring, each read uses its own pre-submitted buffer. Reusing 'iofd->pending' for submitting next read is not possible, as the next read buffer is already submitted.

Instead, create a new msgb which is used for the read operation and, once completed, memcopy to the existing pending buffer, allowing message segments to accumulate until complete.

Change-Id: I08df9736ccc5e9a7df61ca6dcf94629ee010752f --- M src/core/osmo_io.c M src/core/osmo_io_internal.h M src/core/osmo_io_poll.c M src/core/osmo_io_uring.c 4 files changed, 27 insertions(+), 28 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/84/40584/6