Attention is currently required from: dexter, laforge.

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42310?usp=email )

Change subject: global_platform: install_cap_parser: argument groups cannot be nested ......................................................................

Patch Set 2:

(3 comments)

Patchset:

PS2:

I think claude has chased its own tail here a bit. […]

This patch was written before I analyzed pySim with Claude, so if anyone was chasing its own tail here - that was me :) I quickly looked at `gen_install_parameters()` and based on the type hints for arguments (none of them were marked `Optional`) assumed that they're all mandatory and mutually inclusive. Then I realized that actually they're all optional.

File pySim/global_platform/__init__.py:

https://gerrit.osmocom.org/c/pysim/+/42310/comment/894d9651_64ad41ca?usp=ema... : PS2, Line 904: opts.install_parameters_stk is None:

When one of the --install-parameters-* is missing we throw an exception. […]

I'll rework this patch and remove the mutually inclusiveness check completely.

https://gerrit.osmocom.org/c/pysim/+/42310/comment/d557a3f9_b5acaff0?usp=ema... : PS2, Line 905: raise ValueError("Either --install-parameters alone, or all --install-parameters-* must be specified")

I would write "--install-parameters cannot be mixed with --install-parameters-* arguments.". […]

Thanks for confirming. I realized this later while working on the second patch.