Attention is currently required from: fixeria, dexter.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/24012
)
Change subject: filesystem: add unit tests for encoder/decoder methods
......................................................................
Patch Set 12:
(2 comments)
File tests/test_files.py:
https://gerrit.osmocom.org/c/pysim/+/24012/comment/0391820c_ea1d01e8
PS12, Line 56: debug("Testing decode of %s" % name)
Not really critical (for tests), just a tip:
documentation of the Python's logging framework recomme […]
changed.
https://gerrit.osmocom.org/c/pysim/+/24012/comment/72cf4684_09bbde0b
PS12, Line 160: for c in classes:
Can be done a bit simpler: […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/24012
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I02d884547f4982e0b8ed7ef21b8cda75237942e2
Gerrit-Change-Number: 24012
Gerrit-PatchSet: 12
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: Falkenber9 <robert.falkenberg(a)tu-dortmund.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 01 Feb 2023 09:53:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment