Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/libosmo-abis/+/38809?usp=email )
Change subject: ipaccess: Reduce scope of line local variable
......................................................................
Patch Set 1:
(1 comment)
File src/input/ipaccess.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/38809/comment/84c84796_ef7c3c64… :
PS1, Line 871: if (hh->proto == IPAC_PROTO_IPACCESS) {
Maybe we should just do an early return here instead?
[…]
Ah, I see you're doing it in the next patch :)
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/38809?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I9789cbce74f71505e9b7be1445a0a97007ee37da
Gerrit-Change-Number: 38809
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Nov 2024 19:40:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>