[M] Change in osmo-bsc[master]: Clarify type and values of sccp.conn_id - gerrit-log

10 Mar 2023


      Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31796 )
Change subject: Clarify type and values of sccp.conn_id
......................................................................
Patch Set 2:
(1 comment)
File include/osmocom/bsc/gsm_data.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/31796/comment/3e62b7dc_081a1edf 
PS2, Line 332: 0xFFFFFFFF
If this was not your patch, I would expect you to comment on this and suggest defining these values somewhere:
```
#define SCCP_SIGTRAN_CID_UNSET 0xFFFFFFFF
#define SCCP_SIGTRAN_CID_MAX   0x00FFFFFF
```
I think it makes sense here, to improve code readability.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31796
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If019bcbc1e28929fe8d981fef9103835fc6ead2e
Gerrit-Change-Number: 31796
Gerrit-PatchSet: 2
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Fri, 10 Mar 2023 08:56:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment